Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Edit eval message instead of deleting and re-sending #2861

Open
Robin5605 opened this issue Dec 22, 2023 · 1 comment
Open

Edit eval message instead of deleting and re-sending #2861

Robin5605 opened this issue Dec 22, 2023 · 1 comment
Labels
a: utility Related to utility commands: (bot, eval, extensions, jams, reminders, snekbox, utils) s: planning Discussing details t: enhancement Changes or improvements to existing features

Comments

@Robin5605
Copy link
Contributor

I've noticed recently that the bot deletes the eval response message and re-sends a new one if a user edits their code and presses the re-run reaction button. This adds a lot of noise and is distracting when used in #python-discussion. Is there anything preventing us from simply editing the eval response message?

@shtlrs
Copy link
Member

shtlrs commented Dec 23, 2023

Technically, there isn't anything that would prevent us from doing it.

However, when there's a high throughput in the channel, getting a "refresher" instead of having the old eval burried in a pile of newly sent messages can redirect attention to what's trying to be demonstrated by the code evaluation.

Unless someone is spamming the eval command, which can be remediated by a cooldown, I'm not entirely sure about editing the old output.

@wookie184 wookie184 added s: planning Discussing details a: utility Related to utility commands: (bot, eval, extensions, jams, reminders, snekbox, utils) t: enhancement Changes or improvements to existing features labels Jan 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a: utility Related to utility commands: (bot, eval, extensions, jams, reminders, snekbox, utils) s: planning Discussing details t: enhancement Changes or improvements to existing features
Projects
None yet
Development

No branches or pull requests

3 participants