Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add feature to append additional text to nomination reasons #3000

Merged
merged 11 commits into from May 21, 2024
Merged

Add feature to append additional text to nomination reasons #3000

merged 11 commits into from May 21, 2024

Conversation

Esther-Goldberg
Copy link
Member

Implements changes discussed for #2937

@hedyhli hedyhli linked an issue Apr 3, 2024 that may be closed by this pull request
A command to append to a nomination reason #2937
Closed
@wookie184 wookie184 added the s: needs review Author is waiting for someone to review and approve label Apr 14, 2024
wookie184
wookie184 requested changes Apr 22, 2024
View reviewed changes
Copy link
Contributor

@wookie184 wookie184 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't tested yet, but a few comments.

bot/exts/recruitment/talentpool/_cog.py Outdated Show resolved Hide resolved
bot/exts/recruitment/talentpool/_cog.py Outdated Show resolved Hide resolved
bot/exts/recruitment/talentpool/_cog.py Outdated Show resolved Hide resolved
@Xithrius Xithrius added p: 2 - normal Normal Priority s: waiting for author Waiting for author to address a review or respond to a comment t: enhancement Changes or improvements to existing features a: recruitment Related to recruitment: (talentpool) labels May 13, 2024
@Xithrius
Copy link
Member

Hey @Esther-Goldberg, any updates on this PR? Thanks.

wookie184
wookie184 requested changes May 21, 2024
View reviewed changes
Copy link
Contributor

@wookie184 wookie184 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small bit that can be removed since the try/except was added, other than that all looks good. Thanks for working on this!

bot/exts/recruitment/talentpool/_cog.py Outdated Show resolved Hide resolved
@Esther-Goldberg @wookie184
remove error message because issue is already handled in a try/except
c91bf46 
Co-authored-by: wookie184 <wookie1840@gmail.com>
wookie184
wookie184 approved these changes May 21, 2024
View reviewed changes
Copy link
Contributor

@wookie184 wookie184 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great stuff, thanks again 🚀

@wookie184 wookie184 merged commit 9705ac0 into main May 21, 2024
5 checks passed
@wookie184 wookie184 deleted the append-nominations branch May 21, 2024 02:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarkKoz MarkKoz MarkKoz approved these changes

@wookie184 wookie184 wookie184 approved these changes

Assignees
No one assigned
Labels
a: recruitment Related to recruitment: (talentpool) p: 2 - normal Normal Priority s: needs review Author is waiting for someone to review and approve s: waiting for author Waiting for author to address a review or respond to a comment t: enhancement Changes or improvements to existing features
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

A command to append to a nomination reason
4 participants
@Esther-Goldberg @Xithrius @MarkKoz @wookie184