Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Supporting diffs in Github links #2950

Open
VirdanTheBurden opened this issue Mar 9, 2024 · 1 comment
Open

Supporting diffs in Github links #2950

VirdanTheBurden opened this issue Mar 9, 2024 · 1 comment
Labels
a: utility Related to utility commands: (bot, eval, extensions, jams, reminders, snekbox, utils) p: 3 - low Low Priority s: planning Discussing details t: enhancement Changes or improvements to existing features

Comments

@VirdanTheBurden
Copy link
Member

The current system that listens for GitHub links to format and post in a channel cannot handle URLs that point to a diff.

Supporting these types of links as well would allow for users to specifically demonstrate changes that occur in a series of commits, and also reduce future confusion on what kinds of links elicit a response from the bot.

@VirdanTheBurden VirdanTheBurden added p: 3 - low Low Priority a: utility Related to utility commands: (bot, eval, extensions, jams, reminders, snekbox, utils) t: enhancement Changes or improvements to existing features labels Mar 9, 2024
@wookie184
Copy link
Contributor

Is the idea to display entire diffs, or only selected lines in the diff? If it's the entire diff, I think it'd often be too long to fit in a message. Only displaying selected lines could work, though I've found GitHub's UI for selecting/viewing specific lines in diffs isn't as good as for normal files, and (the reason I mention this) this seems potentially quite difficult to implement, given how the GitHub UI lets you select using line numbers from both things being compared.

I think it would help to see a specific case where this could be helpful, to get a better idea of how it would work.

@wookie184 wookie184 added the s: planning Discussing details label Apr 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a: utility Related to utility commands: (bot, eval, extensions, jams, reminders, snekbox, utils) p: 3 - low Low Priority s: planning Discussing details t: enhancement Changes or improvements to existing features
Projects
None yet
Development

No branches or pull requests

2 participants