Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change color of cancel staff infraction button from green to gray #2980

Merged
merged 5 commits into from May 14, 2024
Merged

Change color of cancel staff infraction button from green to gray #2980

merged 5 commits into from May 14, 2024

Conversation

Robin5605
Copy link
Contributor

Closes #2978

@Robin5605 Robin5605 requested a review from mbaruh as a code owner March 26, 2024 18:36
vivekashok1221
vivekashok1221 approved these changes Mar 26, 2024
View reviewed changes
Copy link
Member

@vivekashok1221 vivekashok1221 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🌟

vivekashok1221
vivekashok1221 requested changes Mar 26, 2024
View reviewed changes
Copy link
Member

@vivekashok1221 vivekashok1221 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Slight nit.

bot/exts/moderation/infraction/_views.py Outdated Show resolved Hide resolved
ichard26
ichard26 reviewed Mar 27, 2024
View reviewed changes
Copy link
Member

@ichard26 ichard26 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The view class was intentionally designed to be generic, able to be used to request confirmation for any infraction. Consequently, it was named InfractionConfirmationView. This change, while a change for the better IMO, restricts the class to ban infractions.

Can we please rename the class to BanConfirmationView at least?

@hedyhli hedyhli added a: frontend Related to output and formatting a: moderation Related to community moderation functionality: (moderation, defcon, verification) p: 2 - normal Normal Priority s: waiting for author Waiting for author to address a review or respond to a comment t: enhancement Changes or improvements to existing features labels Mar 29, 2024
@wookie184
Copy link
Contributor

@Robin5605 any update on this?

@Robin5605
Copy link
Contributor Author

@wookie184 I've addressed @ichard26's comment and @vivekashok1221's review. Should be good to go now, let me know if I've missed anything.

wookie184
wookie184 approved these changes May 14, 2024
View reviewed changes
Copy link
Contributor

@wookie184 wookie184 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks

vivekashok1221
vivekashok1221 approved these changes May 14, 2024
View reviewed changes
Copy link
Member

@vivekashok1221 vivekashok1221 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🌟

@wookie184 wookie184 merged commit 4917ddb into main May 14, 2024
5 checks passed
@wookie184 wookie184 deleted the Robin5605-patch-1 branch May 14, 2024 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ichard26 ichard26 ichard26 left review comments

@wookie184 wookie184 wookie184 approved these changes

@vivekashok1221 vivekashok1221 vivekashok1221 approved these changes

@mbaruh mbaruh Awaiting requested review from mbaruh mbaruh is a code owner

Assignees
No one assigned
Labels
a: frontend Related to output and formatting a: moderation Related to community moderation functionality: (moderation, defcon, verification) p: 2 - normal Normal Priority s: waiting for author Waiting for author to address a review or respond to a comment t: enhancement Changes or improvements to existing features
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update ban confirmation button labels and colours
5 participants
@Robin5605 @wookie184 @vivekashok1221 @ichard26 @hedyhli