Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reply to !eval message instead of pinging #2382

Closed
Robin5605 opened this issue Jan 15, 2023 · 6 comments · Fixed by #2999
Closed

Reply to !eval message instead of pinging #2382

Robin5605 opened this issue Jan 15, 2023 · 6 comments · Fixed by #2999
Assignees
Labels
a: utility Related to utility commands: (bot, eval, extensions, jams, reminders, snekbox, utils) status: approved The issue has received a core developer's approval t: enhancement Changes or improvements to existing features

Comments

@Robin5605
Copy link
Contributor

It was discussed in #community-meta if the !eval command should reply to the original command instead of sending a separate message with a ping. Thoughts on this? I'd be willing to PR if accepted.

@wookie184
Copy link
Contributor

Sounds good to me, I don't see why not.

@wookie184 wookie184 added a: utility Related to utility commands: (bot, eval, extensions, jams, reminders, snekbox, utils) t: enhancement Changes or improvements to existing features status: approved The issue has received a core developer's approval labels Jan 15, 2023
@TizzySaurus
Copy link
Contributor

TizzySaurus commented Jan 15, 2023

What would happen when the command is invoked in a non-whitelisted channel? I suppose it'd have to still send a new message that pings in bot-commands?

Also would the reply be ephemeral? We presumably don't want that, since a lot of the time the eval command is used to showcase something, meaning other people need to see the outcome.

And I believe @bj0key, the user who raised this, said they'd like to implement this fwiw @Robin5605

@ionite34
Copy link
Member

Yeah this seems good. Sometimes the eval takes a while and returns a few messages after the original !eval, so it's unclear which eval resulted in the output, the reply would provide a clickable link.

@bj0key
Copy link

bj0key commented Jan 15, 2023

Yeah, I wouldn't mind implementing this. I think it'd also be worth having !timeit also reply on response, for the sake of parity between the two evaluation-based commands.

@e1pupper
Copy link

I can take on this!

@mbaruh
Copy link
Member

mbaruh commented Feb 14, 2023

Sorry for not noticing your message earlier @bj0key, I assigned it to someone else, hope you don't mind.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a: utility Related to utility commands: (bot, eval, extensions, jams, reminders, snekbox, utils) status: approved The issue has received a core developer's approval t: enhancement Changes or improvements to existing features
Projects
None yet
7 participants