Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Addition of CircleCI hook? #431

Open
jrdnbradford opened this issue May 14, 2024 · 1 comment
Open

Addition of CircleCI hook? #431

jrdnbradford opened this issue May 14, 2024 · 1 comment

Comments

@jrdnbradford
Copy link
Contributor

Any interest in a CircleCI pre-commit hook? A schema exists at SchemaStore/schemastore and it seems to fit the other CI/CD-related hooks. I can put in a PR if interested.

@sirosen
Copy link
Member

sirosen commented May 15, 2024

I'm always happy to add more hooks -- I'd gladly look at a PR!
Because there are so many possible schemas and hooks to add, my general attitude has shifted to an "as requested" basis for adding them.

I'd eventually like to reposition this so that check-jsonschema derives most or all of its hooks from a data package with all of schemastore in it. I started on this as a possibility and some other folks did too, but there are some issues which need to be sorted out (correct licensing, automatic update and release process, and then managing reproducibility in pre-commit).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants