Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove extra list copying #7

Open
Julian opened this issue Mar 4, 2024 · 0 comments
Open

Remove extra list copying #7

Julian opened this issue Mar 4, 2024 · 0 comments

Comments

@Julian
Copy link
Member

Julian commented Mar 4, 2024

(Filing this mostly as a reminder after taking a quick look at the code)

A bunch of places materialize Python lists of tokens unnecessarily (by calling list() on some iterable).

This isn't a huge deal as we likely will never really need to deal with giant schemas, but it's unnecessary.
We should instead only do this if/when we ever need to (e.g. to maintain state for our additional parsing).

@Julian Julian added enhancement New feature or request and removed enhancement New feature or request labels Mar 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant