Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for PIK, GPR and others #3962

Closed
4 tasks
DonaldTsang opened this issue Jul 11, 2019 · 10 comments
Closed
4 tasks

Support for PIK, GPR and others #3962

DonaldTsang opened this issue Jul 11, 2019 · 10 comments
Projects

Comments

@DonaldTsang
Copy link

DonaldTsang commented Jul 11, 2019

I would recommend prioritizing FLIF, FUIF, PIK and GPR, the others are there for completeness sake.

@multiSnow
Copy link

multiSnow commented Jul 16, 2019

https://github.com/multiSnow/mcomix3/blob/59e877fc1e8f0ecd23c170ae34acdafbee9089b3/mcomix/mcomix/lib/FlifImagePlugin.py

It is a decoding-only example of FLIF by using libflif or libflif_dec through ctypes.
As mentioned in comment, libflif is still using some global variables, so it would be not thread-safe to directly link into C module.

@DonaldTsang
Copy link
Author

@multiSnow thanks for keeping the record, would hope the FLIF group can get their acts together. Could you decompose the software to pinpoint what is wrong with global variables?

@multiSnow
Copy link

It is already reported in FLIF-hub/FLIF#517 and seems to be fixed by FLIF-hub/FLIF#531, but still not merged.
The global variables appeared in https://github.com/FLIF-hub/FLIF/blob/master/src/common.cpp (grep TODO).

@DonaldTsang
Copy link
Author

Status report?

@madeddy
Copy link

madeddy commented Jun 5, 2020

This issue should IMHO be closed to reduce junk and clutter in the topic lists.
Reason: Deprecated by reality

@radarhere
Copy link
Member

https://github.com/FLIF-hub/FLIF

FLIF development has stopped since FLIF is superseded by FUIF and then again by JPEG XL

https://github.com/cloudinary/fuif

FUIF development has stopped since FUIF is subsumed in JPEG XL

Unless someone says otherwise, I'm going to take this to mean that adding support for those formats is no longer necessary.

@radarhere radarhere changed the title Support for FLIF, FUIF and others Support for PIK, GPR and others Feb 15, 2022
@radarhere
Copy link
Member

SSDV and FRG don't seem to be popular formats by any means. Is there a particular reason you would like support for them?

@madeddy
Copy link

madeddy commented Apr 9, 2022

He states the reason in the first line of the issue opener: I understand this as "because they exist". 😖

I got a possible crazy idea for the format enhancement issues: Why not make a (sort of) permanent issue for this? New and known unsupported formats could be listed/categorized there with a "state of things". Would surely reduce the clutter and workload in the issues somewhat.
Something like:

  • Planned: avif, jpeg xl
  • Watched: webp2
  • Rejected: flif, fuif
  • Outdated: tga

@radarhere
Copy link
Member

radarhere commented Sep 1, 2023

https://github.com/google/pik now states

There is currently no development going on here. Parts of this project have been used in JPEG XL, which is under active development.

and

Note that the bitstream is still under development and not yet frozen.

https://en.wikipedia.org/wiki/JPEG_XL and https://www.phoronix.com/news/Chrome-Deprecating-JPEG-XL refer to PIK only as a "proposal".

So it's possible that this format never actually reached a point where it was intended to be used.

https://github.com/gopro/gpr states

The General Purpose Raw (GPR) is 12-bit raw image coding format that is based on Adobe DNG® standard

Given that, it seems sensible to group that format in with #6482

@radarhere
Copy link
Member

If I understand correctly, SSDV is a subset of the JPEG format - meaning that SSDV images can already be read by Pillow.

It isn't clear if the request here was for reading or saving. It might seem reasonable to want Pillow to be able to open a lesser-known format for "completeness", as images can come from any source, but if the request is for saving, a stronger guarantee that it would be used would be helpful.

Closing. The GPR request can live on in #6842

Pillow automation moved this from Backlog to Closed Sep 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Pillow
  
Closed
Development

No branches or pull requests

4 participants