Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include tests in coverage reports #4173

Merged
merged 6 commits into from Dec 2, 2019
Merged

Conversation

hugovk
Copy link
Member

@hugovk hugovk commented Oct 27, 2019

@hugovk hugovk added the Testing label Oct 27, 2019
@radarhere
Copy link
Member

Why omit check_*, but not 32bit_segfault_check, bench_*, import_all, make_hash, threaded_save or versions?

@hugovk
Copy link
Member Author

hugovk commented Oct 28, 2019

Good question. Let's review whether we still need them at all, can they be deleted? (I'm away from a computer for a few days, so can't check the git logs right now.)

@radarhere
Copy link
Member

Here is the history

@hugovk
Copy link
Member Author

hugovk commented Nov 11, 2019

Here is the history

@wiredfool @cgohlke Would you like to keep any of these files in repo?

@cgohlke
Copy link
Contributor

cgohlke commented Nov 11, 2019

bench_get.py, import_all.py, make_hash.py, threaded_save.py, versions.py - Added in #35. Commit says 'This is Christoph Gohlke's test suite from his personal PIL package'

Would you like to keep any of these files in repo?

No

@hugovk
Copy link
Member Author

hugovk commented Dec 2, 2019

Let's keep them for now. Added to the ignore list.

  • bench_get.py, import_all.py, make_hash.py, threaded_save.py, versions.py - Added in Add Python 3.2 support #35. Commit says 'This is Christoph Gohlke's test suite from his personal PIL package'

Removed.

@radarhere radarhere merged commit 4551d3a into python-pillow:master Dec 2, 2019
@hugovk hugovk deleted the cover-tests branch December 2, 2019 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants