Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate Image.show(command="...") #4646

Merged
merged 5 commits into from
Jun 23, 2020

Conversation

nulano
Copy link
Contributor

@nulano nulano commented May 25, 2020

For #4643

Changes proposed in this pull request:

  • Deprecate the Image.show(command="...") parameter and remove its documentation, because it hasn't been implemented since the PIL fork, and implementing it is non-trivial.

@nulano
Copy link
Contributor Author

nulano commented May 25, 2020

There was a really odd error on GHA Windows PyPy, unrelated to this change:

__________________ ERROR collecting Tests/test_pdfparser.py ___________________
C:\hostedtoolcache\windows\PyPy\3.6.9\x86\site-packages\py\_path\local.py:701: in pyimport
    __import__(modname)
C:\hostedtoolcache\windows\PyPy\3.6.9\x86\site-packages\_pytest\assertion\rewrite.py:143: in exec_module
    source_stat, co = _rewrite_test(fn, self.config)
C:\hostedtoolcache\windows\PyPy\3.6.9\x86\site-packages\_pytest\assertion\rewrite.py:330: in _rewrite_test
    co = compile(tree, fn, "exec", dont_inherit=True)
E   TypeError: expected unicode, got Call object

@hugovk hugovk added the Deprecation Feature that will be removed in the future label May 25, 2020
@radarhere
Copy link
Member

I've created #4695 as an alternative to this, exploring actually implementing command.

src/PIL/Image.py Outdated Show resolved Hide resolved
Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com>
docs/deprecations.rst Outdated Show resolved Hide resolved
Co-authored-by: Andrew Murray <3112309+radarhere@users.noreply.github.com>
src/PIL/Image.py Outdated Show resolved Hide resolved
Co-authored-by: Andrew Murray <3112309+radarhere@users.noreply.github.com>
@radarhere radarhere merged commit 9979eff into python-pillow:master Jun 23, 2020
radarhere added a commit to radarhere/Pillow that referenced this pull request Jun 23, 2020
radarhere added a commit to radarhere/Pillow that referenced this pull request Jun 23, 2020
@nulano nulano deleted the show-command branch June 23, 2020 10:49
radarhere added a commit to radarhere/Pillow that referenced this pull request Jun 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Deprecation Feature that will be removed in the future
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants