Fixed ImageOps expand with tuple border on P image #5615
Merged
+32
−23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
b6b362c changed
expand()so that for a P image inImageOps.expand(), the border color is only filled after attaching the palette.Instead, this PR create a copy of the palette (to avoid modifying the original), calculates the new palette index from that, and then sets the new palette index as the background of the image.
This brings the logic for P and non-P images in
ImageOps.expand()closer together, and resolves #5614 in the process. In that issue, drawing a single rectangle wasn't able to accomodate a multiple border widths being passed in a tuple. This PR removes the rectangle drawing altogether, fixing that.