Only prefer command line tools SDK on macOS over default MacOSX SDK #5828
+22
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
radarhere
force-pushed
the
macos_sdk_path
branch
from
58feec8 to
2ce7dd5
Compare
|
Ok, sure, done. |
|
I tested this PR in conda-forge/pillow-feedstock#102, and it works fine! 🥳 Thanks a lot for the quick handling, much appreciated! :) |
|
Installs fine and tests pass for me on macOS Monterey 12.0.1 with defaults: $ xcrun --show-sdk-path
/Library/Developer/CommandLineTools/SDKs/MacOSX.sdkThanks both! The next scheduled release is 9.0.0 on 2nd January. |
radarhere
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #5827
#5624 changed setup.py on macOS to prefer the command line tools SDK over
xcrun --show-sdk-path. Apparently that was too far however, as conda-forge would like to specify the SDK path.So instead, this PR scales back #5624 to only use the command line tools SDK when
xcrun --show-sdk-pathreturns the default path of/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX.sdk