Raise an error when performing a negative crop #5972
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #5957
At the moment, mixing up the order of the
box
values forcrop()
, so that a negative crop is performed, doesn't raise an error.gives a (0, 0) image.
In the issue, this was done unintentionally by a user, and because no error was raised, they didn't realise their mistake.
This PR raises an error is the right of a crop region is less than the left, or if the bottom of the region is less than the top.
I am presuming that it is uncommon for users to want a negative crop, and more common for users to mix up the order of the values.