Do not call load() before draft() in Image.thumbnail #6539
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#6528 (comment) has pointed out that by calling
load()
at the beginning ofthumbnail()
, the JPEGdraft()
method wouldn't perform any operations.Pillow/src/PIL/Image.py
Line 2476 in ba98fe7
#6186 added the line because
load()
may change the size of the image, and so changethumbnail()
size calculations.This PR rearranges the code to suit both scenarios, so that
load()
is called before size calculations unlessdraft()
returns a result.