Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added getxmp() to WebPImagePlugin #6758

Merged
merged 3 commits into from Nov 26, 2022
Merged

Conversation

radarhere
Copy link
Member

Resolves #6757

@bigcat88
Copy link
Contributor

bigcat88 commented Nov 24, 2022

Are you sure that this will return dictionary and not a bytes when xmp is present?

Just do not see any call to _getxmp

@bigcat88
Copy link
Contributor

Meant return like this:

def getxmp(self):

def getxmp(self):

return self._getxmp(self.tag_v2[XMP]) if XMP in self.tag_v2 else {}

@radarhere
Copy link
Member Author

Yep, you're right. I've updated the commit.

@hugovk
Copy link
Member

hugovk commented Nov 26, 2022

@hugovk hugovk merged commit 066c3ab into python-pillow:main Nov 26, 2022
@hugovk
Copy link
Member

hugovk commented Nov 26, 2022

Thanks!

@radarhere radarhere deleted the webp_getxmp branch November 26, 2022 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can we get getxmp method for WebP images?
3 participants