Fixed writing int as ASCII tag #6800
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hugovk
reviewed
Dec 28, 2022
Tests/test_file_tiff_metadata.py
Outdated
| out = str(tmp_path / "temp.tiff") | ||
| im.save(out, tiffinfo=info) | ||
| for (value, expected) in {b"test": "test", 1: "1"}.items(): |
There was a problem hiding this comment.
Move these to @pytest.mark.parametrize?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #6799
The image from the issue has a GPSLongitudeRef tag that should be ASCII, but is instead SHORT.
The tag is loaded as an int then, not a string as expected, and when Pillow tries to save it as a string, it fails.
This PR simply changes TiffImagePlugin to convert the variable to a string.