Add LCMS2 flags to ImageCms #7676
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…re.CmsProfile references (cherry picked from commit f2b1bbc)
radarhere
reviewed
Jan 2, 2024
| _GRIDPOINTS_16 = 16 << 16 | ||
| _GRIDPOINTS_32 = 32 << 16 | ||
| _GRIDPOINTS_64 = 64 << 16 | ||
| _GRIDPOINTS_128 = 128 << 16 |
There was a problem hiding this comment.
The purpose of these _GRIDPOINTS_ flags is not for independent use, but rather so that when you look at _MAX_FLAG or the returned values of GRIDPOINTS(), you see the numbers expressed as flags, not just integers, yes?
radarhere
reviewed
Jan 2, 2024
Co-authored-by: Andrew Murray <3112309+radarhere@users.noreply.github.com>
radarhere
approved these changes
Jan 6, 2024
hugovk
approved these changes
Jan 6, 2024
Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While adding type hints to ImageCms, I found that the FLAGS dict is based on lcms1 and has not been updated for lcms2.
Changes proposed in this pull request:
ImageCms.Flagslisting all flags from LCMS2-2.16'slcms2.has a subclass ofenum.IntFlagfor better type hinting (in a future PR). I plan to create a second PR for deprecating the old names inImageCms.FLAGS. Edit: Deprecate ImageCms constants and versions() function #7702ImageCms.DirectionandImageCms.Intentenums, andImageCms.ImageCmsProfileclass.ImageCms.core.CmsProfile(incorrectly listed withoutcore).