-
-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Default --no-interactive to on when CI=true #232
Comments
I like the idea, but I am hesitant. Is the |
I’ve never heard of a CI system that doesn’t set that environment variable to |
There are certainly plenty that don't do it automatically, but it certainly is a common convention. Most users of environments where it is not set implicitly will set it manually @Secrus, so I do not see the harm (though Poetry should probably grow a 'using Poetry in CI' FAQ entry that mentions this). |
Thanks for the suggestion! I think we should go a step further and default See #245 |
@branchvincent @Secrus I don’t think the implemented solution necessarily solves the problem I reported. Some CI systems (like Buildkite) allocate a TTY by default because they want processes to output colour. However they still set the |
By setting
--no-interactive
to on when the environment variableCI
istrue
, we can help avoid situations where a CI pipeline accidentally blocks waiting for user input when none will arrive. This will help prevent precious compute resources from being wasted.The text was updated successfully, but these errors were encountered: