Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

poetry export doesn't include non-optional groups #8109

Open
jonapich opened this issue Jun 15, 2023 · 3 comments · May be fixed by python-poetry/poetry-plugin-export#212
Open

poetry export doesn't include non-optional groups #8109

jonapich opened this issue Jun 15, 2023 · 3 comments · May be fixed by python-poetry/poetry-plugin-export#212
Labels
kind/bug Something isn't working as expected status/triage This issue needs to be triaged

Comments

@jonapich
Copy link
Contributor

jonapich commented Jun 15, 2023 •
edited

The poetry export --help description mentions this:

--with=WITH The optional dependency groups to include.

However, it must also be used to include non-optional groups.

e.g.:

Given the following example pyproject.toml: https://gist.github.com/jonapich/80b8090d610da02d5de5137ca96da253

I get the following trace:

> poetry export | grep tenacity
(empty)

> poetry export --with my | grep tenacity
tenacity==8.2.2 ; python_version >= "3.8" and python_version < "3.12" \

I'm on poetry 1.5.1 on Windows, but it was reproduced on Linux as well.
@jonapich jonapich added kind/bug Something isn't working as expected status/triage This issue needs to be triaged labels Jun 15, 2023
@Secrus
Copy link
Member

Secrus commented Jun 15, 2023

This is by design. Feel free to make a PR changing the description of the command if you think it's wrong. If you don't plan on making a PR, please close the issue.

https://python-poetry.org/docs/cli/#export

image

@jonapich
Copy link
Contributor Author

Is there a rationale behind this inconsistency?

@jonapich jonapich linked a pull request Jun 16, 2023 that will close this issue
Open
@radoering
Copy link
Member

This was done to avoid a breaking change. See #5413 (review)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/bug Something isn't working as expected status/triage This issue needs to be triaged
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

reword the --with help text and deprecate --without jonapich/poetry-plugin-export
3 participants
@jonapich @Secrus @radoering