From 455c0b27edb286b7123b58e4433f0dc6ca02cd2d Mon Sep 17 00:00:00 2001 From: Jakub Urban Date: Fri, 11 Nov 2022 06:36:29 +0100 Subject: [PATCH] pip install --no-input everywhere (#6966) This is an extension of https://github.com/python-poetry/poetry/pull/6724. I think `pip install` invoked by poetry should never ask for user input. Motivation is that it happened to myself and a number of colleagues many times that poetry got seemingly stuck while it was just waiting for a user input because of a private pypi repository that needed authentication. I hope this is a valuable contribution to a tool I like a lot and would like to use more and more :) --- src/poetry/inspection/info.py | 1 + src/poetry/installation/pip_installer.py | 2 +- src/poetry/utils/env.py | 1 + tests/utils/test_env.py | 1 + 4 files changed, 4 insertions(+), 1 deletion(-) diff --git a/src/poetry/inspection/info.py b/src/poetry/inspection/info.py index 665fd641c84..54372b54176 100644 --- a/src/poetry/inspection/info.py +++ b/src/poetry/inspection/info.py @@ -593,6 +593,7 @@ def get_pep517_metadata(path: Path) -> PackageInfo: "install", "--disable-pip-version-check", "--ignore-installed", + "--no-input", *PEP517_META_BUILD_DEPS, ) venv.run( diff --git a/src/poetry/installation/pip_installer.py b/src/poetry/installation/pip_installer.py index 884dd1895df..60d672abc54 100644 --- a/src/poetry/installation/pip_installer.py +++ b/src/poetry/installation/pip_installer.py @@ -46,7 +46,7 @@ def install(self, package: Package, update: bool = False) -> None: return - args = ["install", "--no-deps"] + args = ["install", "--no-deps", "--no-input"] if not package.is_direct_origin() and package.source_url: assert package.source_reference is not None diff --git a/src/poetry/utils/env.py b/src/poetry/utils/env.py index 74a5de8aa76..4c60cf9e46c 100644 --- a/src/poetry/utils/env.py +++ b/src/poetry/utils/env.py @@ -1953,6 +1953,7 @@ def build_environment( "install", "--disable-pip-version-check", "--ignore-installed", + "--no-input", *poetry.pyproject.build_system.requires, ) diff --git a/tests/utils/test_env.py b/tests/utils/test_env.py index 52f1352dd5b..dcd379302e8 100644 --- a/tests/utils/test_env.py +++ b/tests/utils/test_env.py @@ -1535,6 +1535,7 @@ def test_build_environment_called_build_script_specified( "install", "--disable-pip-version-check", "--ignore-installed", + "--no-input", *extended_without_setup_poetry.pyproject.build_system.requires, ] ]