Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Source Trove classifiers from canonical PyPA definitions #2579

Closed
2 tasks done
kdeldycke opened this issue Jun 18, 2020 · 6 comments · Fixed by #2881
Closed
2 tasks done

Source Trove classifiers from canonical PyPA definitions #2579

kdeldycke opened this issue Jun 18, 2020 · 6 comments · Fixed by #2881
Labels
kind/feature Feature requests/implementations

Comments

@kdeldycke
Copy link
Contributor

  • I have searched the issues of this repo and believe that this is not a duplicate.
  • I have searched the documentation and believe that my question is not covered.

Feature Request

I just stumble upon https://github.com/pypa/trove-classifiers , a package published and maintained by PyPA that is cataloguing all current and deprecated classifiers recognized on pypi.org . This is the canonical source of all trove definitions.

I propose to rely on this package to validate and check classifiers produced by poetry. Is that a good idea?

@kdeldycke kdeldycke added kind/feature Feature requests/implementations status/triage This issue needs to be triaged labels Jun 18, 2020
@kdeldycke
Copy link
Contributor Author

Oh. One more thing: with the advance of a plugin system in the upcoming Poetry 1.1 release (see: #1856), shouldn't we send there a PR to add a new classifier dedicated to Poetry? Something like: Framework :: Poetry.

@pradyunsg
Copy link
Contributor

For a new classifier, a request needs to be made to PyPI admins, and one of the criterion is that the classifier is immediately useful to at least 10 other packages/package maintainers (to avoid the case of adding classifiers for folks' pet projects that no one else uses).

I think it'd be worthwhile to wait until after the 1.1 release, before requesting for addition of the trove classifier.

@kdeldycke
Copy link
Contributor Author

@pradyunsg oh yes you're right. In the mean time I checked the criterions for new inclusion and indeed, the classifier needs an existing base of relative popularity before being admitted into the reference. And I totally get it to not pollute the catalogue with short-lived or unmaintained projects.

@abn
Copy link
Member

abn commented Jun 19, 2020

@kdeldycke I think it is reasonable to add this into the check command. I'd be hesitent to enforce this elsewhere however.

@kdeldycke
Copy link
Contributor Author

Thanks @abn for the suggestion! I just pushed a PR at #2881 that is doing exactly that.

neersighted pushed a commit that referenced this issue Sep 18, 2022
Inspects trove classifiers on `check` CLI command calls, and look for
unrecognized and deprecated categories.

Adds dependency https://github.com/pypa/trove-classifiers, a package
published and maintained by the PyPA that is cataloguing all classifiers.
This is the canonical source of all trove definitions.

Resolves: #2579
@mkniewallner mkniewallner removed the status/triage This issue needs to be triaged label Sep 18, 2022
Copy link

github-actions bot commented Mar 1, 2024

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
kind/feature Feature requests/implementations
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants