-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Poetry 2.0 removals and other breaking changes #9136
Comments
maybe an opportunity to do something about |
and also to take a view on |
A humble 🙏 that if
This would then be much less disruptive for users of tools such as |
(Sorry if this is not the right place to add an Issue on this version.) One problem I noticed is whenever Poetry tries to add a For example, I'm working on the following
which makes sense because dep group is not a thing in 621. |
Thanks for reporting this. I fixed it and added a test.
Since it's an open PR that is not yet merged, you can report issues directly in #9135. |
I think it'd be nice to also get rid of the deprecated |
Yes, we should take a look at all of the deprecated command line options. |
Is there any chance that some of these changes could be enabled via feature flags? I'm particularly interested in #3248 but this could be generally useful for easing the community into most of the listed breaking changes. Perhaps something like: [tool.poetry.future]
lock-no-update-by-default = true Of course doing this would mean maintaining two different code paths, but that's something the maintainers would have to weigh against the benefits of early feedback and (hopefully) a smoother transition. |
No. The reason for a major version bump is for us to have an opportunity to cleanup the code. Maintaining multiple code paths goes against that goal. |
suggest to make |
Looking at the changelog, we've had already some breaking changes in the configuration format:
Here we're discussing some additional breaking changes on the configuration. Would it make sense having some metadata (say, in |
Although I mostly use
There is #3316. I think we are open to adding a version constraint so the user can define compatible poetry versions.
I think that could cause more confusion than it helps respectively increases the maintainance burden. In the end,
At the moment, your best chance is the first line of |
I don't have a strong opinion, but I do myself use I would lean towards making it the default because it feels more "pure" (e.g., by default Poetry will always make sure that you get the same environment as others on the same platform). The counter would be if some users install "extra" things into their venv often and are frustrated that now Poetry uninstalls them. I'd call this an anti-pattern and they should be putting these things in Overall, I would support making |
This issue tracks possible removals and other breaking changes we want to include if the next release (or the one after that) will be a major release. (That does not mean that the changes listed here cannot be included in a minor release after a decent deprecation period.)
Please add a comment if you have concerns or would like to include another pending breaking change that is not on the list.
Background & Motivation
As support for PEP 621 is slowly taking shape (see #9135 to track the current state) and this will be a big, significant change (even if the old way will still be supported), this might be the time for a major version bump. Even if we try to avoid obvious breaking changes, just not ignoring the
project
section anymore will be a subtle breaking change for anyone who is already using this section (for whatever reason). Further, since supporting PEP 621 requires massive changes in many areas of the code, the risk of unintentional breaking changes is higher than usual.Long story short: If we do a major version bump anyway, we should make use of it and remove things / add breaking changes we were holding back so far.
Candidates
Disclaimer: decision is not final and might be subject to change
poetry-plugin-export
secondary
anddefault
poetry shell
poetry self
lock --no-update
the defaultinstall --sync
the default--keep-untracked
or similarno-setuptools
config optionThe text was updated successfully, but these errors were encountered: