Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate setup.py metadata to setup.cfg #413

Closed
Tracked by #412
lieryan opened this issue Sep 26, 2021 · 5 comments
Closed
Tracked by #412

Migrate setup.py metadata to setup.cfg #413

lieryan opened this issue Sep 26, 2021 · 5 comments

Comments

@lieryan
Copy link
Member

lieryan commented Sep 26, 2021

No description provided.

@lieryan lieryan changed the title setup.py Migrate setup.py metadata to pyproject.toml Sep 26, 2021
@lieryan
Copy link
Member Author

lieryan commented Oct 3, 2021

Currently, setuptools does not support putting most project metadata in pyproject.toml. It still only supports reading metadata from setup.cfg. So this is not possible right now. If you want a fully pyproject.toml-based project, you'll need to move off setuptools. Currently, we have a rather simple build process, so setuptools works just fine for us, so it's unlikely we'll move off setuptools in the foreseeable future.

Changing the scope of this ticket to move metadata into setup.cfg instead.

@lieryan lieryan changed the title Migrate setup.py metadata to pyproject.toml Migrate setup.py metadata to setup.cfg Oct 3, 2021
@lieryan
Copy link
Member Author

lieryan commented Oct 4, 2021

It seem like build might allow us to do away with setuptools/setup.py entirely, so doing a full pyproject.toml might actually be possible here.

@bagel897
Copy link
Contributor

bagel897 commented May 9, 2022

Build is a frontend to the pyproject.toml build backends. I have written a pyproject.toml, which works for normal installs. However, setuptools does not support editable installations yet with pyproject.toml. Options are to use the PDM (or another PEP 660 compliant backend) or wait for setuptools to update.

@bagel897
Copy link
Contributor

This issue can be closed #473

@lieryan
Copy link
Member Author

lieryan commented Jun 18, 2022

Thanks @bageljrkhanofemus. We've already been building using build for some time. With the pyproject.toml migration, this is no longer necessary.

@lieryan lieryan closed this as completed Jun 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants