introduce task handle base class #479
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lieryan
reviewed
Jun 3, 2022
rope/base/taskhandle.py
Outdated
| class TaskHandle: | ||
| class BaseJobSet(ABC): | ||
| @abstractmethod | ||
| def started_job(self, name: Optional[str]) -> None: |
There was a problem hiding this comment.
Should this really be Optional[str]? The job name should always be passed in, right?
|
Thank you for making this improvement |
lieryan
added
the
api-change
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Introduces a base task handle (and job set) class. I noticed that NullTaskHandle and TaskHandle did not provide identical APIs so I used ABC base classes to do so. I also created a method to increment the count of a job set for autoimport and used that.
This will break any jobsets which didn't match the TaskHandle API.
Since the increment method is abstract, it will break jobsets without it as well. I can make it non-abstract but that seems like bad practice.
Checklist (delete if not relevant):