Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue with parsing function call args list #507

Merged
merged 2 commits into from Oct 5, 2022

Conversation

lieryan
Copy link
Member

@lieryan lieryan commented Oct 5, 2022

Description

This PR fixes issue with parsing function call args list

Also, simplify legacy handling of Call node from the days of Python 2 when there were more restrictions on the ordering of positional, Starred, and keyword arguments.

Fixes #506

Checklist (delete if not relevant):

  • I have added tests that prove my fix is effective or that my feature works
  • I have updated CHANGELOG.md

Also, simplify legacy handling of Call node from the days of Python 2
when there were more restrictions on the ordering of positional,
Starred, and keyword arguments.
@lieryan lieryan added this to the 1.4.0 milestone Oct 5, 2022
@lieryan lieryan self-assigned this Oct 5, 2022
@lieryan lieryan merged commit 2fa7726 into master Oct 5, 2022
@lieryan lieryan deleted the lieryan-506-parsing-starred-args branch October 5, 2022 03:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Starred arguments sandwiched between other positional arguments fails to parse
1 participant