Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix test that sometimes leaves files behind in the current working directory #604

Merged
merged 2 commits into from Dec 16, 2022

Conversation

lieryan
Copy link
Member

@lieryan lieryan commented Dec 16, 2022

Description

Fix test that sometimes leaves files behind in the current working directory

Also, convert the test to pytest style test since the test was essentially re-written from scratch anyway.

Checklist (delete if not relevant):

  • I have added tests that prove my fix is effective or that my feature works
  • I have updated CHANGELOG.md

…irectory

Also, convert the test to pytest style test since the test was
essentially re-written from scratch anyway.
@lieryan lieryan self-assigned this Dec 16, 2022
@lieryan lieryan merged commit 0eb895b into master Dec 16, 2022
@lieryan lieryan deleted the fix-test-isolation branch December 16, 2022 04:48
@lieryan lieryan added this to the 1.7.0 milestone Dec 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant