Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove call_for_nodes(recursive) argument #634

Merged
merged 3 commits into from Jan 3, 2023
Merged

Remove call_for_nodes(recursive) argument #634

merged 3 commits into from Jan 3, 2023

Conversation

lieryan
Copy link
Member

@lieryan lieryan commented Jan 3, 2023

Description

This PR consists of only this commit from edreamleo:

@lieryan lieryan added this to the 1.7.0 milestone Jan 3, 2023
@lieryan lieryan enabled auto-merge January 3, 2023 04:28
@lieryan lieryan disabled auto-merge January 3, 2023 04:29
@lieryan lieryan enabled auto-merge January 3, 2023 04:30
@lieryan lieryan merged commit d05424b into master Jan 3, 2023
@lieryan lieryan deleted the remove-non-recursive-call-for-nodes branch January 3, 2023 04:33
@edreamleo
Copy link
Contributor

@lieryan Thanks for this PR. I have merged it into #633.

I'm still trying to understand call_for_nodes and would appreciate any guidance you can give.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.7.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@lieryan @edreamleo