PR: remove unnecessary eval in generate.py #640
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lieryan
approved these changes
Jan 4, 2023
|
Thank you for fixing this @edreamleo It seems to be used by It probably should've been documented, or ropemode should've used a documented interface instead. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A nit, discovered while investigating the unit test framework. The eval does not seem like a security problem :-)
The new code does, however, reinforce the docstring.
Hmm.
create_generatedoes not appear anywhere in Rope except for the two unit tests that test it. Nor do the docs mentioncreate_generate. What's going on?