Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR: Remove a do-nothing statement in soi._handle_first_parameter #680

Merged
merged 1 commit into from Mar 6, 2023
Merged

PR: Remove a do-nothing statement in soi._handle_first_parameter #680

merged 1 commit into from Mar 6, 2023

Conversation

edreamleo
Copy link
Contributor

@edreamleo edreamleo commented Mar 5, 2023

The then-clause of an if statement was pass.

@lieryan
Copy link
Member

lieryan commented Mar 6, 2023

Hi @edreamleo, thanks for fixing this.

I wonder what was the intent for this empty block was.

If I had to guess, this was probably supposed to be an if--elif chain and the empty block was supposed to be an early return from the method.

Not quite sure whether the lack of early return would have caused any issues, but if it's been a decade without an issue, removing it probably would be fine.

@lieryan lieryan merged commit 35569ac into python-rope:master Mar 6, 2023
@lieryan lieryan added this to the 1.8.0 milestone May 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants