-
Notifications
You must be signed in to change notification settings - Fork 236
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GHA of PSR 9.7.0 does not respect git_committer_name
and git_committer_email
anymore
#918
Comments
I'm thinking this is a bug I introduced by accident during my refactor. Thanks for the notification. You can set it in the configuration file if you want to but obviously any local release would also use the configured value. |
I thought so. I did not touch my configuration, and it stopped working the way it used to from 9.6 to 9.7. You updated the "get git details" in |
git_committer_name
and git_committer_email
anymore?git_committer_name
and git_committer_email
anymore
🎉 This issue has been resolved in version 9.7.1 🎉The release is available on: |
git_committer_name
and git_committer_email
anymoregit_committer_name
and git_committer_email
anymore
The problem
I used the GHA of PSR 9.6.0 with
git_committer_name
andgit_committer_email
configured to let the release commit be from the GitHub bot with its avatar icon. Updating to PSR 9.7.0 now I get commits made bysemantic-release <semantic-release>
. Do I need to change something or is this a bug in 9.7.0?Expected behavior
I expected the committer to still be
github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
.Environment
Do you need this information, if I have a problem using the GHA?
See: https://github.com/afuetterer/services-test4
Please state which OS you are using and provide the output of the following commands:
Please also indicate which Python build tool(s) you are using (e.g.
pip
,build
,poetry
, etc.), including the version number too.Configuration
Logs
See: https://github.com/afuetterer/services-test4/actions/runs/8966931525/job/24623457653
Note: This is only a dummy project to test things out.
Additional context
Example commits from before and after updating to 9.7.0:
The text was updated successfully, but these errors were encountered: