Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: the equality checks for DNSPointer and DNSService should be case insensitive #1122

Merged
merged 3 commits into from Dec 24, 2022

Conversation

bdraco
Copy link
Member

@bdraco bdraco commented Dec 24, 2022

The name check is already using the key (lowercase value) but the server and alias did not use their respective keys

There are likely more cases where we don't handle this perfectly https://datatracker.ietf.org/doc/html/rfc4343#section-2

fixes #1121

@codecov-commenter
Copy link

codecov-commenter commented Dec 24, 2022

Codecov Report

Base: 99.72% // Head: 99.72% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (a00710d) compared to base (3a25ff7).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1122   +/-   ##
=======================================
  Coverage   99.72%   99.72%           
=======================================
  Files          22       22           
  Lines        2590     2591    +1     
  Branches      456      456           
=======================================
+ Hits         2583     2584    +1     
  Misses          5        5           
  Partials        2        2           
Impacted Files Coverage Δ
src/zeroconf/__init__.py 100.00% <100.00%> (ø)
src/zeroconf/_dns.py 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@bdraco bdraco marked this pull request as ready for review December 24, 2022 03:27
@bdraco bdraco merged commit 48ae77f into master Dec 24, 2022
@bdraco bdraco deleted the equality_checks_caseless branch December 24, 2022 03:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DNSService and DNSPointer equality check should be case insensitive
2 participants