Further optimize distribution() searching. #272
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Locally, this speeds up
distribution("ipython")
on a large-ishenvironment by nearly 2-fold. (The GHA benchmark goes from ~1.6ms
to ~0.8ms.)
All the following changes matter for the performance gain:
(See https://gitlab.com/python-devs/importlib_metadata/-/issues/95 for
rationale why performance matters.)