Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Honor '/'-separated names in ResourceContainer.joinpath. #249

Merged
merged 2 commits into from Apr 17, 2022

Conversation

jaraco
Copy link
Member

@jaraco jaraco commented Apr 14, 2022

No description provided.

@FFY00
Copy link
Member

FFY00 commented Apr 14, 2022

I know this was initially mentioned in #248 (comment) but I can't seem to find where that promise is made. Would you be able to point it out to me?

IMO adding this to the interface isn't great, but if a promise exists already, this is indeed a correct fix.

@jaraco
Copy link
Member Author

jaraco commented Apr 14, 2022

See python/cpython#91298 and the latest docstring for Traversable.joinpath.

@jaraco jaraco merged commit 8dceab3 into main Apr 17, 2022
@jaraco jaraco deleted the bugfix/resource-container-pathsep branch April 17, 2022 00:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants