Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default configs should merge with the user config #134

Open
stsewd opened this issue Nov 28, 2020 · 0 comments
Open

Default configs should merge with the user config #134

stsewd opened this issue Nov 28, 2020 · 0 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@stsewd
Copy link
Member

stsewd commented Nov 28, 2020

Currently we load the default config when the user doesn't have one, but we actually should merge them.

lira/lira/app.py

Lines 25 to 27 in 8688d7c

default_config = {
"books": ["lira.books.intro"],
}

@stsewd stsewd added enhancement New feature or request good first issue Good for newcomers labels Nov 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant