Introduce templateOptions.json file to Control Training Options for Each Template #330
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… template individually
✅ Deploy Preview for code-generator ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
@vfdev-5 @theory-in-progress I have completed work on this issue and it seems to work for now, I think we should merge this in a new branch |
|
@guptaaryan16 can you create |
vfdev-5
reviewed
Sep 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I have added a new file
templateOptions.jsonto control options for each template individually. This is done to allow templates to have specific configurations for each template and make it easy to contribute new template that may not support a particular runner liketorchrunor a backend likespawn. If it is successfully merged, we would expect the sma e for other options likeHandlersandLoggers.Fix #308
Additional context
What is the purpose of this pull request?