Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom Metrics Example #46

Open
Ishan-Kumar2 opened this issue Oct 1, 2021 · 10 comments
Open

Custom Metrics Example #46

Ishan-Kumar2 opened this issue Oct 1, 2021 · 10 comments
Labels
Hacktoberfest For Hacktoberfest available issues help wanted Extra attention is needed how-to-guide Improvements or additions in how-to guides PyDataGlobal2021 For the mentored PyData Global Sprint

Comments

@Ishan-Kumar2
Copy link
Contributor

A tutorial which shows how custom metrics can be made using Metric class would be useful.
The example can create an easy metric like the Levenshtein Distance between two strings.
Reference - https://pytorch.org/ignite/metrics.html#how-to-create-a-custom-metric

@Priyansi
Copy link
Collaborator

Priyansi commented Oct 1, 2021

Thank you for this great suggestion @Ishan-Kumar2 ! I agree this would be really helpful. If we are going to implement just one metric, perhaps, this would better be suited as a how-to guide. If we are talking about implementing more than one custom metric, we can label this as a tutorial. Would you like to work on this issue?

@Ishan-Kumar2
Copy link
Contributor Author

Having it as a how-to-guide sounds good. I am happy to implement it once I am done with the NMT example. Till we can tag it as a help-wanted for new contributors, what do you say?

@Priyansi
Copy link
Collaborator

Priyansi commented Oct 1, 2021

Yes sounds good! I'll also attach the hacktoberfest label.

@Priyansi Priyansi added Hacktoberfest For Hacktoberfest available issues help wanted Extra attention is needed how-to-guide Improvements or additions in how-to guides labels Oct 1, 2021
@Priyansi Priyansi added the PyDataGlobal2021 For the mentored PyData Global Sprint label Oct 21, 2021
@mdrpanwar
Copy link
Contributor

@Priyansi Could you please assign this to me? I would like to work on this how-to guide.

@Priyansi
Copy link
Collaborator

Yeah sure, that'd be great! Feel free to ask any questions either here on Discord (for faster replies).

@vfdev-5
Copy link
Member

vfdev-5 commented Oct 29, 2021

@mdrpanwar any updates on this issue ?

@mdrpanwar
Copy link
Contributor

@vfdev-5 I am working on it and it's mostly complete. I will raise the PR today.

@vfdev-5
Copy link
Member

vfdev-5 commented Oct 29, 2021

Sounds great, thanks a lot !

@Priyansi
Copy link
Collaborator

Hey @mdrpanwar , are you facing any issues with this? Any updates?

@vfdev-5
Copy link
Member

vfdev-5 commented Nov 29, 2021

@mdrpanwar could you please submit your draft PR such that we could finish it from our side. Thanks !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Hacktoberfest For Hacktoberfest available issues help wanted Extra attention is needed how-to-guide Improvements or additions in how-to guides PyDataGlobal2021 For the mentored PyData Global Sprint
Projects
None yet
Development

No branches or pull requests

4 participants