-
-
Notifications
You must be signed in to change notification settings - Fork 648
Update sphinx to 4.2.0 #2261
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update sphinx to 4.2.0 #2261
Conversation
When merging this PR, I would suggest to add Line 5 in ed5e1dd
And remove Taken from pytorch. |
@trsvchn can you share your findings about sphinx 4.X here please and move forward with this PR. |
Yeah, That's good idea! |
Similar idea to upgrade sphinx, but they ended up with 3.5.4 Looks like new sphinx generates html with another structure, and the theme css should be adjusted |
kindly asking @ydcjeff for the final review! :) |
@trsvchn we have "Notes" folded but others unfolded, can we make all unfolded ? Code snippets are more compacted:
Otherwise, OK for me |
Snippets are now ok, thanks for spotting that! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks @trsvchn !
I think we can pause on unfolding Notes for this PR.
Hi sorry for not helping on this :( |
Fixes #2224
Description:
Update sphinx to 4.2.0
Note: before merging:
.github/workflows/install_docs_deps.sh
Check list: