Skip to content

#2313 fix bug in StateParamScheduler attach method #2316

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Nov 15, 2021

Conversation

fco-dv
Copy link
Contributor

@fco-dv fco-dv commented Nov 9, 2021

Fixes #2313

Description:
Fixing bug on StateParamScheduler attach method, add related test.
Check list:

  • New tests are added (if a new feature is added)
  • New doc strings: description and/or example code are in RST format
  • Documentation is updated (if required)

Sorry, something went wrong.

@github-actions github-actions bot added the module: handlers Core Handlers module label Nov 9, 2021
@sdesrozis
Copy link
Contributor

@fco-dv Thank you, I left a comment.

Copy link
Contributor

@KickItLikeShika KickItLikeShika left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @fco-dv, left a comment!

Copy link
Collaborator

@vfdev-5 vfdev-5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @fco-dv

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@vfdev-5 vfdev-5 enabled auto-merge (squash) November 15, 2021 22:53
@vfdev-5 vfdev-5 merged commit a168476 into pytorch:master Nov 15, 2021
fco-dv added a commit to fco-dv/ignite that referenced this pull request Nov 23, 2021
* pytorch#2313 fix bug in StateParamScheduler attach method

* pytorch#2313 add assert if KeyError is raised

* pytorch#2313 update test_multiple_scheduler_with_save_history

Co-authored-by: vfdev <vfdev.5@gmail.com>
Ishan-Kumar2 pushed a commit to Ishan-Kumar2/ignite that referenced this pull request Dec 26, 2021
* pytorch#2313 fix bug in StateParamScheduler attach method

* pytorch#2313 add assert if KeyError is raised

* pytorch#2313 update test_multiple_scheduler_with_save_history

Co-authored-by: vfdev <vfdev.5@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
module: handlers Core Handlers module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

StateParamScheduler raises KeyError when save_history=true and multiple parameters are scheduled
4 participants