Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Procedural/algorithmic dataarrays as input for modifiers/composites #2693

Open
mraspaud opened this issue Dec 15, 2023 · 1 comment
Open

Comments

@mraspaud
Copy link
Member

Feature Request

This is a feature missing to satpy for a while in my opinion: the possibility to have generated/procedural input data to modifiers or composites in satpy.

Is your feature request related to a problem? Please describe.
This has been brought up before, for example in #77

On top of that example with sun/sensor angles, a discussion with @strandgren regarding the cloud detection in #2557 revealed that there is not dedicated place for algorithms to live in satpy. For example, in that PR, the composite needs some kind of cloud classification. The compositor object is now taking care of this, but it feels a bit out of place to have this in a compositor. On top of that, there are level 2 products giving much better cloud classifications, and these could be used when available instead of the thresholding algorithm defined in the PR.

Describe the solution you'd like
I would like to have the possibility to have procedural input, generated from different algorithm, available for users when the provided data is lacking.

Describe any changes to existing user workflow
I propose:

  1. To add an new type of classs,es very similar to Compositors but called eg Generators instead.
  2. That the generators would have clear standard_names to be able to match them with actual data of the same type so that:
  3. When an input to a given composite is lacking from the data, the corresponding generator would be used.

All in all, I don't think this would amount to a lot of changes in satpy, but it would make things clearer IMO.

Additional context
Even a plugin system for this could be implemented.

@mraspaud mraspaud changed the title Procedural/algoritmic dataarrays as input for modifiers/composites Procedural/algorithmic dataarrays as input for modifiers/composites Dec 15, 2023
@djhoese
Copy link
Member

djhoese commented Dec 15, 2023

If the classes are treated like the existing components then the existing plugin system should be easy to update to support them. For what it is worth GeoIPS calls these "algorithms" I believe.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants