Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pylint issue 4118: Pylint 2.7.0 seems to ignore the min-similarity-lines setting #2672

Closed
andy-maier opened this issue Apr 25, 2021 · 1 comment · Fixed by #2861
Closed

Pylint issue 4118: Pylint 2.7.0 seems to ignore the min-similarity-lines setting #2672

andy-maier opened this issue Apr 25, 2021 · 1 comment · Fixed by #2861
Assignees
@andy-maier
Labels
resolution: elsewhere resolution: fixed
Milestone
1.5.0

Comments

@andy-maier
Copy link
Contributor

andy-maier commented Apr 25, 2021 •
edited

This issue is to track the corresponding pylint issue pylint-dev/pylint#4118.
See also the comment in file pylintrc.
@andy-maier andy-maier self-assigned this Apr 25, 2021
andy-maier added a commit that referenced this issue Aug 8, 2021
@andy-maier
Removed Pylint pinning to 2.7.0 and addressed Pylint issues
30070c6 
Details:

* Pylint: Removed pinning of Pylint to <2.7.0 because the performance issue
  can also be addressed by disabling the similarity checker, and addressed
  Pylint issues reported by Pylint 2.9. (issue #2672)

Signed-off-by: Andreas Maier <andreas.r.maier@gmx.de>
@andy-maier
Copy link
Contributor Author

andy-maier commented Aug 8, 2021 •
edited

PR #2601 mitigated the issue by disabling the similarity checker (disable=R0801 in pylintrc file).

A solution in Pylint is expected for Pylint 2.10.0.

andy-maier added a commit that referenced this issue Aug 17, 2021
@andy-maier
Removed Pylint pinning to 2.7.0 and addressed Pylint issues
750e0b0 
Details:

* Pylint: Removed pinning of Pylint to <2.7.0 because the performance issue
  can also be addressed by disabling the similarity checker, and addressed
  Pylint issues reported by Pylint 2.9. (issue #2672)

Signed-off-by: Andreas Maier <andreas.r.maier@gmx.de>
andy-maier added a commit that referenced this issue Aug 17, 2021
@andy-maier
Removed Pylint pinning to 2.7.0 and addressed Pylint issues
056b43b 
Details:

* Pylint: Removed pinning of Pylint to <2.7.0 because the performance issue
  can also be addressed by disabling the similarity checker, and addressed
  Pylint issues reported by Pylint 2.9. (issue #2672)

Signed-off-by: Andreas Maier <andreas.r.maier@gmx.de>
andy-maier added a commit that referenced this issue Aug 22, 2021
@andy-maier
Removed Pylint pinning to 2.7.0 and addressed Pylint issues
832c28e 
Details:

* Pylint: Removed pinning of Pylint to <2.7.0 because the performance issue
  can also be addressed by disabling the similarity checker, and addressed
  Pylint issues reported by Pylint 2.9. (issue #2672)

Signed-off-by: Andreas Maier <andreas.r.maier@gmx.de>
andy-maier added a commit that referenced this issue Aug 24, 2021
@andy-maier
Removed Pylint pinning to 2.7.0 and addressed Pylint issues
3b07116 
Details:

* Pylint: Removed pinning of Pylint to <2.7.0 because the performance issue
  can also be addressed by disabling the similarity checker, and addressed
  Pylint issues reported by Pylint 2.9. (issue #2672)

Signed-off-by: Andreas Maier <andreas.r.maier@gmx.de>
andy-maier added a commit that referenced this issue Mar 11, 2022
@andy-maier
Increased pylint to >=2.10 on Python >=3.6 to pick up fixes
685d13f 
Details:

* Increased pylint to >=2.10 on Python >=3.6 to pick up fixes in similarity
  checker (issues #2672, #2673)

Signed-off-by: Andreas Maier <andreas.r.maier@gmx.de>
@andy-maier andy-maier added this to the 1.5.0 milestone Mar 11, 2022
@andy-maier andy-maier linked a pull request Mar 11, 2022 that will close this issue
Increased pylint to >=2.10 on Python >=3.6 to pick up fixes #2861
Merged
andy-maier added a commit that referenced this issue Mar 11, 2022
@andy-maier
Increased pylint to >=2.10 on Python >=3.6 to pick up fixes
142c1d2 
Details:

* Increased pylint to >=2.10 on Python >=3.6 to pick up fixes in similarity
  checker (issues #2672, #2673)

* Enabled the similarity chcker of pylint again on pylint >=2.10.

Signed-off-by: Andreas Maier <andreas.r.maier@gmx.de>
andy-maier added a commit that referenced this issue Mar 11, 2022
@andy-maier
Increased pylint to >=2.10 on Python >=3.6 to pick up fixes
50dda0d 
Details:

* Increased pylint to >=2.10 on Python >=3.6 to pick up fixes in similarity
  checker (issues #2672, #2673)

* Enabled the similarity chcker of pylint again on pylint >=2.10.

Signed-off-by: Andreas Maier <andreas.r.maier@gmx.de>
andy-maier added a commit that referenced this issue Mar 13, 2022
@andy-maier
Increased pylint to >=2.10 on Python >=3.6 to pick up fixes
8d08553 
Details:

* Increased pylint to >=2.10 on Python >=3.6 to pick up fixes in similarity
  checker (issues #2672, #2673)

* Enabled the similarity chcker of pylint again on pylint >=2.10.

Signed-off-by: Andreas Maier <andreas.r.maier@gmx.de>
andy-maier added a commit that referenced this issue Mar 14, 2022
@andy-maier
Increased pylint to >=2.10 on Python >=3.6 to pick up fixes
de6bb46 
Details:

* Increased pylint to >=2.10 on Python >=3.6 to pick up fixes in similarity
  checker (issues #2672, #2673)

* Enabled the similarity chcker of pylint again on pylint >=2.10.

Signed-off-by: Andreas Maier <andreas.r.maier@gmx.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@andy-maier andy-maier

Labels
resolution: elsewhere resolution: fixed
Projects
None yet
Milestone
1.5.0
Development

Successfully merging a pull request may close this issue.

Increased pylint to >=2.10 on Python >=3.6 to pick up fixes pywbem/pywbem
1 participant
@andy-maier