-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
removeWormhole triggers error in Ember 3.22 #70
Comments
I unfortunately don't have time to continue working on this addon, but if anyone would like to solve it PRs are welcome! |
Bummer :'( |
|
Looks like `removeWormhole` can get called in the same cycle as `didInsertELement`, and both touch `item.nodes`, which triggers an error in Ember 3.22 that looks something like this: ``` Uncaught Error: Assertion Failed: You attempted to update `nodes` on `<EmberObject:ember169>`, but it had already been used previously in the same computation. Attempting to update a value after using it in a computation can cause logical errors, infinite revalidation bugs, and performance issues, and is not supported. `nodes` was first used: .... ``` To work around this for now (probably not the best way) we postpone the update to the next turn of the rendering loop.
@pzuraq If you won't have time to maintain this addon any more, perhaps you'd like to migrate it to |
Yeah that sounds like a good idea, I'll reach out to them |
This appears related to yapplabs/ember-modal-dialog#312
liquid-wormhole/addon/components/liquid-destination.js
Lines 63 to 73 in 5c17aa3
I don't know yet if the problem is here in
liquid-wormhole
orember-modal-dialog
where it is used, but when upgrading to Ember 3.22 I started running into errors like the following (see also emberjs/ember.js#19110):The text was updated successfully, but these errors were encountered: