Skip to content
This repository has been archived by the owner on Sep 28, 2021. It is now read-only.

Improve response from status when invalid app #396

Open
carlioth opened this issue Sep 3, 2019 · 3 comments
Open

Improve response from status when invalid app #396

carlioth opened this issue Sep 3, 2019 · 3 comments
Labels
bug Something isn't working v2

Comments

@carlioth
Copy link
Contributor

carlioth commented Sep 3, 2019

When running corectl with app in config file, and the app doesn't exist the status command will not give a good response.

corectl -c local-corectl.yaml status

ERROR could not open app with ID '1fa8a65f-855e-4f7c-bbdc-1f81739e1d96': Could not find app: App not found (1003)

Inform that the app doesn't exist, but also print engine information.

@carlioth carlioth added the bug Something isn't working label Sep 3, 2019
@wennmo
Copy link
Member

wennmo commented Sep 3, 2019

Supplying an app to the status command will trigger a different flow since a session towards the app will be opened instead to supply info regarding the data model etc.

Not a bug in my opinion since an invalid parameter was passed.

@carlioth
Copy link
Contributor Author

carlioth commented Sep 3, 2019

Looking at the status help text:

status Print status info about the connection to the engine and current app

I would expect to get info about engine and current app. How do I know that supplying an app will trigger a different flow?

@wennmo
Copy link
Member

wennmo commented Sep 3, 2019

I was more referring to that supplying invalid parameters to a command should result in a fatal error -> exit code 1. At least that is the approach we have for other commands.

As an end-user I would want the command to fail if I had faulty params in e.g. my config, but lets take a discussion on what should be included in the status command. I agree that we need to do a retake on what should be presented.

@wennmo wennmo added the v2 label Sep 9, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working v2
Projects
None yet
Development

No branches or pull requests

2 participants