Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some types for stardust hooks are incorrect or not complete #906

Open
haxxmaxx opened this issue Aug 31, 2022 · 0 comments
Open

Some types for stardust hooks are incorrect or not complete #906

haxxmaxx opened this issue Aug 31, 2022 · 0 comments
Labels
api-stardust JavaScript library for building mashups

Comments

@haxxmaxx
Copy link
Collaborator

haxxmaxx commented Aug 31, 2022

馃悰 Bug report

When using some methods that we get for some hooks, the typing is incorrect. Either there is a property missing so it has to be extended or some argument types are incorrect so the TS errors has to be ignored. More specifically

  • the blur method on useKeyboard says it has 0 arguments when it actually has 1
  • useSelections is missing methods on and removeListener. Not sure if this is intentional, guessing they are inherited somehow
  • useTranslator is missing method language
  • useTheme is missing name

Steps to Reproduce

  1. Use any of the mentioned hooks
  2. Try to call any of the mentioned methods

Expected behavior

All methods on a hook should be typed correctly

Actual behavior

For keyboard hook you get this
Screenshot 2022-08-31 at 16 32 37

Versions

  • nebula.js: 3.0.0-alpha11
  • Platform: N/A
  • Browser: N/A

Additional context

(Add any other context, link to demo or screenshots about the issue.)

@haxxmaxx haxxmaxx added the api-stardust JavaScript library for building mashups label Aug 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api-stardust JavaScript library for building mashups
Projects
None yet
Development

No branches or pull requests

1 participant