Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sub-panel should close when clicked outside #195

Open
pernyl opened this issue Mar 21, 2023 · 2 comments
Open

Sub-panel should close when clicked outside #195

pernyl opened this issue Mar 21, 2023 · 2 comments
Labels
bug Something isn't working prio4

Comments

@pernyl
Copy link
Contributor

pernyl commented Mar 21, 2023

Sub panel is only closed if you click on the sheet.

It is not closed if you click in the PP, in the sub toolbar, in the topbar or in the assetpanel.

Should probably listen to outside clicks.

@pernyl pernyl added bug Something isn't working prio4 labels Mar 21, 2023
@cosmar26 cosmar26 self-assigned this Mar 28, 2023
@cosmar26 cosmar26 reopened this Apr 14, 2023
@cosmar26
Copy link
Contributor

Re-opening the issue as the previous solution doesn't cover some use cases for the side panel when used from Straight Table

@johanlahti
Copy link
Collaborator

The new Straight Table works the same way as ours do. At least in these scenarios, where it does not close:

  • Click inside PP
  • Click on toolbar or left side-bar
  • Changing properties inside PP

It closes only when the selected chart is deselected.

If we decide to change this behaviour, we need to sync it with the Straight Table's implementation so it works consistently.

I would also argue that the current solution is ok. And I think you can argue for the other way too (a matter of taste? 😄 ).

Closing for now.

@cosmar26 cosmar26 reopened this Apr 26, 2023
@cosmar26 cosmar26 removed their assignment May 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working prio4
Projects
None yet
Development

No branches or pull requests

3 participants