Skip to content
This repository has been archived by the owner on Mar 19, 2024. It is now read-only.

Build: Fix incompatability with node-resolve 14 #750

Closed
Caele opened this issue Nov 25, 2022 · 2 comments
Closed

Build: Fix incompatability with node-resolve 14 #750

Caele opened this issue Nov 25, 2022 · 2 comments
Labels
dependencies Pull requests that update a dependency file

Comments

@Caele
Copy link
Collaborator

Caele commented Nov 25, 2022

The nebula.js/cli-build version 3.0.4 includes a dependecy update of @rollup/plugin-node-resolve to v14 (but 15 has the same issue). This somehow breaks the table in particular, and stops it from working properly

The Nebula PR is this: qlik-oss/nebula.js#946
The change in @rollup/plugin-node-resolve is rollup/plugins#1245

The actual error:

---> BUILDING SUPERNOVA
No name was provided for external module “stream” in “output.globals” – guessing “require$$7$1”.
Creating a browser bundle that depends on Node.js built-in modules (“stream”). You might need to include https://github.com/FredKSchott/rollup-plugin-polyfill-node

Early googling suggests that it could be a problem with the typescript plugin or config, but no luck yet.

@Caele Caele added the dependencies Pull requests that update a dependency file label Nov 25, 2022
@haxxmaxx
Copy link
Collaborator

what happened to this one? seems like nebula is not using v14 at all anymore?

@haxxmaxx
Copy link
Collaborator

we are way passed version 3.0.4 of cli-build. Closing this

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

No branches or pull requests

2 participants