Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fails to generate declarationMaps #260

Merged
merged 1 commit into from Aug 12, 2023
Merged

Conversation

2wheeh
Copy link
Contributor

@2wheeh 2wheeh commented Aug 7, 2023

resolves #259

I found that #259 happens after 284c77f.

I just restored this change from the latest (63321c2),
which makes it generate .map files for .d.ts files well (checked on bac2a7d).

and It seems #254 is not reproduced 馃(checked on b041a4c).
not-reproduce- 254

@qmhc
Copy link
Owner

qmhc commented Aug 12, 2023

This reverts the fix of 284c77f, refer #254.

@qmhc qmhc merged commit 86298b6 into qmhc:main Aug 12, 2023
4 checks passed
@qmhc
Copy link
Owner

qmhc commented Aug 12, 2023

and It seems #254 is not reproduced 馃(checked on b041a4c).

After building, useWakeLock.d.ts was not generated, and error TS4078 for useWakeLock.ts in the console.

@2wheeh
Copy link
Contributor Author

2wheeh commented Aug 12, 2023

@qmhc It seems this error TS4078 occurred because of typescript version. (not because of this revert)
With typescript @5.1.6, error TS4078 doesn't appear and useWakeLock.d.ts is generated. (d70bd45)

error TS4078 appears on #254's reproduction codes as well with typescript @5.0.4.
->

ts-4078-react-wake-lock-5

@qmhc
Copy link
Owner

qmhc commented Aug 12, 2023

@2wheeh Nice job!

The reason I encountered this issue because I used the link protocol locally, and the TypeScript version was based on the vite-dts-plugin project.

Thanks for taking the time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Source map files not generated when exported on entry
2 participants