-
-
Notifications
You must be signed in to change notification settings - Fork 37.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
For kinesis/kint41 keyboard, do not enter lower-power sleep mode when on the ChibiOS idle thread (#23053). #23054
Conversation
… on the ChibiOS idle thread (qmk#23053).
This doesn't do anything. |
Hi, fauxpark. Can you please elaborate on why you commented (and presumably think) that "This doesn't do anything"? Adding |
Hi, fauxpark, please see 416af01 for the commit that switched all keyboards to |
Sounds like something is wrong with the MIMXRT1062 code in ChibiOS then. |
Hi Ryan,
Thanks for the replies. Can you please accept this pull request as a
workaround until the root cause is found and fixed? Perhaps with an
additional comment in the code that this is likely only necessary because
something is wrong with the MIMXRT1062 code in ChibiOS? I'm all for fixing
the root problem, but, until you accept this pull request, Kinesis Teensy
4.1 keyboards cannot enjoy QMK Configurator
<https://config.qmk.fm/#/kinesis/kint41/LAYOUT>. My personal enjoyment of
my kinesis/kint41 keyboard was delayed by a couple hours until I learned
enough about QMK and found kinx-project/kint#77.
Wouldn't you prefer that users such as myself can enjoy the fruits of your
labor in the meantime? Thanks for your consideration.
…-Steve
On Mon, Feb 12, 2024 at 6:39 PM Ryan ***@***.***> wrote:
Sounds like something is wrong with the MIMXRT1062 code in ChibiOS then.
—
Reply to this email directly, view it on GitHub
<#23054 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/BFS3N42PE7BV2W3EMR2YVT3YTKRZJAVCNFSM6AAAAABDDU3J4CVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMZZG44DSOJTGU>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Teensy 4.x boards are barely supported by QMK as it is. |
Hi Ryan,
Thanks again for the quick reply. What is the benefit to QMK of rejecting
the pull request?
…-Steve
On Mon, Feb 12, 2024 at 7:48 PM Ryan ***@***.***> wrote:
Teensy 4.x boards are barely supported by QMK as it is.
—
Reply to this email directly, view it on GitHub
<#23054 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/BFS3N42UOSPG3FVOGK7ARYTYTKZ4JAVCNFSM6AAAAABDDU3J4CVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMZZHEZDOOJYGE>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
That's not what I'm saying. This is not a bug in QMK, it is a bug in ChibiOS. You need to take it up there. |
For clarity, the ChibiOS code for MIMXRT1062 was apparently written purely for the kint41. It seems to be a bare-bones and potentially broken implementation -- it's been reported that anything to do with timing in QMK is flat-out broken on MIMXRT1062-based boards. I've attached two files -- disassembly from before and after applying the PR. Apart from the kinesis_kint41_default.elf.base.dis.txt I'd say the general issue here is that the usual interrupts aren't firing, and ChibiOS isn't scheduling the QMK main thread for execution as a result. Interrupts such as USB or SysTick tend to keep QMK running, and perhaps these aren't enabled in the MIMXRT1062 port. Also something to at least try -- ChibiOS creates an idle thread even though QMK should be running as a hard loop -- you could try adding |
Description
For kinesis/kint41 keyboard, do not enter lower-power sleep mode when on the ChibiOS idle thread (#23053).
Types of Changes
Issues Fixed or Closed by This PR
Checklist