Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate the possibility to port to UglifyJS 2 #4

Open
ChALkeR opened this issue May 2, 2016 · 3 comments
Open

Investigate the possibility to port to UglifyJS 2 #4

ChALkeR opened this issue May 2, 2016 · 3 comments

Comments

@ChALkeR
Copy link
Member

ChALkeR commented May 2, 2016

Probably after #3.

@ChALkeR
Copy link
Member Author

ChALkeR commented Jun 7, 2016

This is technically possible and not so hard to do, but the new output from UglifyJS2 is much more vebrose — this means that the runtime will consume more memory and will require to load larger files from the server when in pre-parsed mode.

We could investigate converting that into a shorter form suitable to use by qmlweb, though, but that will still slow down parsing.

Also, the parser itself became about two times larger (and I included only the required files).

@ChALkeR
Copy link
Member Author

ChALkeR commented Jun 7, 2016

Filed a patch to uglify-js@2 that will allow us to wrap tokenizer() method in the meantime: mishoo/UglifyJS#1113 (it's somewhy not exported in uglify-js@2, but was exported in uglify-js@1).

Update: merged.

@ChALkeR
Copy link
Member Author

ChALkeR commented Jun 7, 2016

uglify-js-2 branch has some initial work, mostly broken. It also requires the abovementioned UglifyJS2 patch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant