Handle development version increments according to SemVer specification #93
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
According to SemVer 2.0.0 §4 breaking changes do not increment the major version.
bastidest
changed the title
|
Oh I wasn't aware of that. Thx a lot. I'll release a new version. |
|
Done. Version |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As stated in SemVer 2.0.0 §4, breaking changes in development versions (0.y.z) are indicated by a patch or minor version increment. Currently this project treats development versions the same as stable versions.
This PR changes the version increment behavior for development versions by never updating the major version in development versions.
Before
After
I also added some basic tests to validate this behavior.