-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: always include breaking changes in changelog #96
Conversation
Hi @bastidest, thanks for this PR. I totally agree on the functionality, however I'd like to have a slightly different implementations. I would prefer to move the whole filter logic into |
e.g. changelogGenerator.generateMarkdown(changelogCommits, {
releaseName: "FooBar",
customMarkdown: "lorum ipsum",
messageRegex: ...,
scopes: [...],
...
}); |
I very much agree. I was being cautious not to break anything and thought i could surgically insert the fix 🥷. I did it properly now and removed the "marking". I was having a hard time tracing back all object fields, so I started documenting with JSDoc to assist the IDE. |
LGTM |
I'll release a new version tomorrow. |
feel free to try version |
Closes #95